-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating Stencil components with Angular/Vue/React/Ionic broken?? because breaking changes removed dist/loader #1649
Comments
Don't know what changed. but suddenly it started working. |
No, it still does not work with Ionic 4 if I use import { defineCustomElements } from 'mycomponent/dist/loader'; Module not found: Error: Can't resolve '../dist/esm/legacy/loader.mjs' in .......... if I import it the old way: import { defineCustomElements } from 'my-component/loader'; the error is the following: Module not found: Error: Can't resolve '../dist/esm/polyfills/index.js' |
Yep same
…On Sat, 22 Jun 2019 at 20:37, Andrei Drynov ***@***.***> wrote:
No, it still does not work if I use
import { defineCustomElements } from 'mycomponent/dist/loader';
*Module not found: Error: Can't resolve '../dist/esm/legacy/loader.mjs' in
..........*
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1649?email_source=notifications&email_token=AAFZT6VGHIXN42J5YCR6BADP3Z5OPA5CNFSM4HYXPUSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYKQATQ#issuecomment-504692814>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFZT6TYA6AUJSB3GNBSS4DP3Z5OPANCNFSM4HYXPUSA>
.
|
Is there anyway to make this work ? It used to work well with angular 6... Doesn't work with angular 7 :((( |
I have updated the docs to ensure they link to the correct location for the loader. https://stenciljs.com/docs/vue. Also be sure that you are using the latest release of Stencil at this time. v1.1.6 |
in edge can not work (Listen、Method、component lifecycle connectedCallback does not work ) |
Whats the solution? |
i am having the same issue with no wrapper around my stencil module. But defineCustomElements(window) method work great for a minute, then it stopped being able to locate the correct loader |
is there any update on this? |
Stencil version:
I'm submitting a:
[X] bug report
[X] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/
Current behavior:
Known breaking changes in Stencil 1.. require changing how Stencil components are used in Angular/Vue/React/Ionic project, with insufficient guidance on how to navigate the change.
Expected behavior:
Modify the "breaking changes" doc to provide a possible way for at least one of these systems.
Steps to reproduce:
-Build a component using Stencil/core^1.0.0
-Publish to NPM
-Include in another project by the method which has been recommended for Stenci/core^0..
typically
dist/loader
was not found, or similar.See for example these bug reports:
-#1351
-#1574
-#1636
-#1662
Related code:
Other information:
The breaking changes doc tells us:
So it looks like the reason
/dist/loader
is not found is that this file is no longer needed. That's great! However, it isn't clear how to include astencil
component in another framework.What does one include, if
dist/loader
no longer exists?Do we still import
defineCustomElements
?Is it still recommended to call
defineCustomElements
on the window?What would resolve the issue
2-3 lines which suggest the new way to
It is fine if the answer is generic; we just need something to point us in the right direction.
The text was updated successfully, but these errors were encountered: