feat(taskQueue): set "async" taskQueue as default

Update taskQueue default to "async". Stencil 1 default was "congestionAsync".
ionic-team · Aug 4, 2020 · f3bb121 · f3bb121
1 parent 55331be
commit f3bb121
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/src/compiler/config/test/validate-config.spec.ts b/src/compiler/config/test/validate-config.spec.ts
@@ -309,4 +309,15 @@ describe('validation', () => {
     expect(config.extras.initializeNextTick).toBe(false);
     expect(config.extras.tagNameTransform).toBe(false);
   });
+
+  it('should set taskQueue "async" by default', () => {
+    const { config } = validateConfig(userConfig);
+    expect(config.taskQueue).toBe('async');
+  });
+
+  it('should set taskQueue', () => {
+    userConfig.taskQueue = 'congestionAsync'
+    const { config } = validateConfig(userConfig);
+    expect(config.taskQueue).toBe('congestionAsync');
+  });
 });
diff --git a/src/compiler/config/validate-config.ts b/src/compiler/config/validate-config.ts
@@ -1,5 +1,5 @@
 import { Config, ConfigBundle, Diagnostic } from '../../declarations';
-import { buildError, buildWarn, isBoolean, isNumber, sortBy } from '@utils';
+import { buildError, buildWarn, isBoolean, isNumber, isString, sortBy } from '@utils';
 import { setBooleanConfig } from './config-utils';
 import { validateDevServer } from './validate-dev-server';
 import { validateDistNamespace } from './validate-namespace';
@@ -58,11 +58,8 @@ export const validateConfig = (userConfig?: Config) => {
   setBooleanConfig(config, 'validateTypes', null, !config._isTesting);
   setBooleanConfig(config, 'allowInlineScripts', null, true);
 
-  if (typeof config.taskQueue !== 'string') {
-    config.taskQueue = 'congestionAsync';
-  } else if (config.taskQueue === ('sync' as any)) {
-    // deprecated 1.12.1
-    config.taskQueue = 'immediate';
+  if (!isString(config.taskQueue)) {
+    config.taskQueue = 'async';
   }
 
   // hash file names