Skip to content

Commit

Permalink
chore(telemetry): remove info task telemetry call (#3487)
Browse files Browse the repository at this point in the history
this commit removes a telemetry call from stencil for the info task.
this call never actually worked, and is something that we don't feel we
want/need to collect.

it also has an additional positive side effect for making the stencil
configuration entity stricter - this call was placed before
loading/validating a configuration (because doing so is not required to
run the info task, making it faster). as `ValidatedConfig` grew in size,
additional fields were added to make a bespoke validated config.
removing this call removes the need to maintain the config used, making
the process of making `ValidatedConfig` stricter slightly easier
  • Loading branch information
rwaskiewicz authored Jul 26, 2022
1 parent 22d9858 commit 6fba6bb
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions src/cli/run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,7 @@ export const run = async (init: d.CliInitOptions) => {
loadedCompilerLog(sys, logger, flags, coreCompiler);

if (task === 'info') {
await telemetryAction(
sys,
{ flags: createConfigFlags({ task: 'info' }), logger, outputTargets: [] },
coreCompiler,
async () => {
await taskInfo(coreCompiler, sys, logger);
}
);
taskInfo(coreCompiler, sys, logger);
return;
}

Expand Down

0 comments on commit 6fba6bb

Please sign in to comment.