keep current default behavior

ionic-team · Jun 18, 2024 · 5eaf004 · 5eaf004
1 parent 185d03e
commit 5eaf004
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/testing/puppeteer/puppeteer-declarations.ts b/src/testing/puppeteer/puppeteer-declarations.ts
@@ -28,6 +28,7 @@ export interface NewE2EPageOptions extends WaitForOptions {
   failOnNetworkError?: boolean;
   /**
    * If set to `true`, Stencil will log failing network requests
+   * @default true
    */
   logFailingNetworkRequests?: boolean;
 }

diff --git a/src/testing/puppeteer/puppeteer-page.ts b/src/testing/puppeteer/puppeteer-page.ts
@@ -115,7 +115,8 @@ export async function newE2EPage(opts: NewE2EPageOptions = {}): Promise<E2EPage>
 
     const failOnConsoleError = opts.failOnConsoleError === true;
     const failOnNetworkError = opts.failOnNetworkError === true;
-    const logFailingNetworkRequests = opts.logFailingNetworkRequests === true;
+    const logFailingNetworkRequests =
+      typeof opts.logFailingNetworkRequests === 'boolean' ? opts.logFailingNetworkRequests : true;
 
     page.on('console', (ev) => {
       if (ev.type() === 'error') {