Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(testing): add recipe for setViewport #1191

Merged
merged 6 commits into from
Jul 31, 2023

Conversation

tanner-reits
Copy link
Member

Updates testing documentation with a recipe for setViewport to emulate device displays within e2e tests.

@tanner-reits tanner-reits requested a review from a team as a code owner July 28, 2023 15:16
@tanner-reits tanner-reits requested review from rwaskiewicz and alicewriteswrongs and removed request for a team July 28, 2023 15:16
@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 7:05pm

Copy link
Contributor

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just two small things

docs/testing/e2e-testing.md Show resolved Hide resolved
versioned_docs/version-v2/testing/config.md Outdated Show resolved Hide resolved
Copy link
Contributor

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think @alicewriteswrongs called everything out that that we should tweak

@tanner-reits tanner-reits merged commit dabe853 into main Jul 31, 2023
@tanner-reits tanner-reits deleted the treits/add-emulation-to-e2e-docs branch July 31, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants