Pull Request: Updated Karma to Version 2 #87
+3,603
−654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been using these versions without any issues, thanks! |
|
I needed to add --single-run to the end of the npm run test command to close the browser after the tests complete. |
|
It is working great for me so far. |
|
I works 👌🏽 |
|
We have just updated our project to use these values and everything seems to work. Would be great if this could be merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests updates Karma to
^2.0.0along with various related packages.I may not have gone far enough with this update, but it unit tests and E2E tests are working.
I am looking for any feedback.