Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 15 updates in source code not available in npm #284

Closed
ericis opened this issue Apr 7, 2023 · 5 comments
Closed

Angular 15 updates in source code not available in npm #284

ericis opened this issue Apr 7, 2023 · 5 comments

Comments

@ericis
Copy link

ericis commented Apr 7, 2023

The published npm package is 2+ years old. The January updates to support Angular 15 have not been published. This package now completely breaks applications because of issue #281

@mlynch
Copy link
Contributor

mlynch commented Apr 11, 2023

Could use some help with this. I'm not an expert on building angular modules using the new system. There was an attempt here but I struggled to get the files built correctly so angular can see them #269

@ericis
Copy link
Author

ericis commented Apr 13, 2023

🤔 I'll try removing "@ionic/storage-angular", adding "@ionic/storage" and then creating the IonicStorageModule step by step in my Angular project to see if I come across anything obvious.

@mlynch I am shocked and pleased to see a CEO of what I consider to be a very successful company in the comments let alone in the code. Kudos to you and the company culture!

@ericis
Copy link
Author

ericis commented Apr 14, 2023

Replacing the dependency on "@ionic/storage-angular" with "@ionic/storage" and then (re-)creating the IonicStorageModule inside of my Angular 15.2.6 project's code worked successfully:
https://github.com/ourchitecture/fidlit/blob/main/src/fidlit.app/src/app/services/storage.service.ts

I had to make some small adjustments to the original source code. However, I would be surprised if any of those adjustments are what is causing the failures seen in #269 . 🤔

@maxbeba
Copy link

maxbeba commented May 6, 2023

@ericis Thanks for the workaround. Worked for me.
But this should really be fixed. :-D

@sean-perkins
Copy link
Contributor

Hello everyone 👋 I've release v4.0.0 which should resolve the pending issues. Please open a new issue if you experience any issues with the new release.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants