Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): pass disabled down to input when it is set from form #9994

Merged
merged 1 commit into from
Jan 13, 2017
Merged

fix(input): pass disabled down to input when it is set from form #9994

merged 1 commit into from
Jan 13, 2017

Conversation

brandyscarney
Copy link
Member

fixes #9834

@brandyscarney
fix(input): pass disabled down to input when it is set from form
580b964 
- test modified to disable username and comments on `input/form-inputs`
and then toggle them via a button

see: http://g.recordit.co/RkN510TcHk.gif

fixes #9834
@brandyscarney
Copy link
Member Author

Released a nightly with this in it: [email protected]

@brandyscarney brandyscarney mentioned this pull request Jan 12, 2017
Closed
@brandyscarney brandyscarney added this to the 2.0.0-rc.6 milestone Jan 12, 2017
@mhartington mhartington mentioned this pull request Jan 12, 2017
Closed
@adamdbradley adamdbradley merged commit 5844a83 into master Jan 13, 2017
@brandyscarney brandyscarney deleted the fix-disabled-inputs branch January 13, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdbradley adamdbradley Awaiting requested review from adamdbradley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.6
Development

Successfully merging this pull request may close these issues.

ion-input ignores the disabled attribute when created using a FormControl in a Reactive Form
2 participants
@brandyscarney @adamdbradley