fix(ion-backdrop): new ion-backdrop can prevent background scrolling #6687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
New
ion-backdrop
component can prevent background scrolling fixing: #6656 in Alerts, Popover, actionsheet, loading...Changes proposed in this pull request:
Replace all
<div class="backdrop" ...>
with<ion-backdrop>
MenuBackdrop
is not longed neededWe don't longer have to listen for
touchmove
events!! performant solutionBackdrop injects a class at
body
level in order to prevent scrolling:Bonus: this code was repeated all over the place, now it is much more compact.
Before:
After:
Ionic Version: 2.x
Fixes: #6656