fix(viewLifecycle): move event emit after transition cleanup #4715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now view lifecycle events can fire before the transition is fully cleaned up, meaning our past view can be in a
leaving
state instead ofcached
when the new view's$ionicView.enter
is triggered.This fixes #2939 where this code would not correctly clear the last view because it is marked
leaving
rather thancached
in the navViewController.clearCache function:The fix was to move the event emit to the bottom of transitionCompleted in
viewSwitcher.js