exposeAsideWhen directive bug fix #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msalcala11
force-pushed
the
exposeAsideWhenFix
branch
from
c52208c to
8187367
Compare
mlynch
added a commit
that referenced
this pull request
Dec 6, 2015
exposeAsideWhen directive bug fix
|
Thanks, definitely a bit of incorrect back and forth on the resize event 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3600 by ensuring that the side menu changes position only when $window.matchMedia changes from valid to invalid and vice versa, rather than listening to every resize event to trigger a change.
Since Ionic broadcasts a resize event on every popover and modal show action, this ensures that opening a popover located in the side-menu does not close the side menu, which is an issue that has been mentioned in the following ionic forum posts:
http://forum.ionicframework.com/t/menu-left-closes-when-popover-show/21476
http://forum.ionicframework.com/t/bug-side-menu-with-expose-aside-when-will-close-by-itself-when-a-modal-or-popover-comes-up/14532
http://forum.ionicframework.com/t/popover-in-side-menu-how-to-stop-side-menu-close/12277