fix(menu): emit ionMenuChange when re-mounted

[liamdebeasi]

Issue number: resolves #28030

---

What is the current behavior?

ion-menu registers itself with the menu controller when connectedCallback fires and then unregisters itself when disconnectedCallback fires. When the menu was removed from the DOM, disconnectedCallback was not always being fired due to ionic-team/stencil#4070.

ion-menu-button checks to see if it should be visible by grabbing the current menu in

ionic-framework/core/src/components/menu-button/menu-button.tsx

Line 74 in 314055c

this.visible = await updateVisibility(this.menu);

.

Since disconnectedCallback was not being fired, ion-menu-button would still find the menu even when it was no longer in the DOM. In this case, the menu was not being unregistered due to disconnectedCallback not firing.

When the linked Stencil bug was resolved in Stencil 4.0.3, the menu button started to disappear. This is happening because disconnectedCallback is now correctly called when the menu is removed from the DOM. Since disconnectedCallback is called, the menu is un-registered from the menu controller, and the menu button can no longer find it.

However, this revealed a long-standing bug where re-adding the menu would not fire ionMenuChange again. As a result, the menu button remained hidden.

What is the new behavior?

• The menu now fires ionMenuChange on connectedCallback as long as componentDidLoad has already been run.

Does this introduce a breaking change?

• Yes
• No

Other information

Dev build: 7.3.2-dev.11692803611.15c1bc87

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sean-perkins]

The most minor nit, implementation looks good.

[averyjohnston]

If I click the button multiple times, the menu is still present in the DOM but the menu button disappears; is that what's supposed to happen? 🤔

[liamdebeasi]

It looks like connectedCallback fires then disconnectedCallback, so it could be a Stencil bug. I was able to reproduce this behavior even after I removed the fix.