Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Repeat: Use root scope when checking for in-progress digest #1518

Closed
wants to merge 3 commits into from
Closed

Collection Repeat: Use root scope when checking for in-progress digest #1518

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ba3301
Use root scope when checking in-progress digest
mrwade May 29, 2014
0d0e975
Merge branch 'master' of https://github.com/driftyco/ionic
mrwade May 30, 2014
7ef8d7c
Inject $rootScope into $collectionDataSource for digest detection
mrwade May 31, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions js/angular/service/collectionRepeatDataSource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ IonicModule
.factory('$collectionDataSource', [
'$cacheFactory',
'$parse',
function($cacheFactory, $parse) {
'$rootScope',
function($cacheFactory, $parse, $rootScope) {
var nextCacheId = 0;
function CollectionRepeatDataSource(options) {
var self = this;
Expand Down Expand Up @@ -119,7 +120,7 @@ function($cacheFactory, $parse) {
this.transcludeParent[0].appendChild(item.element[0]);
}
reconnectScope(item.scope);
!item.scope.$$phase && item.scope.$digest();
!$rootScope.$$phase && item.scope.$digest();
},
getLength: function() {
return this.data && this.data.length || 0;
Expand Down