Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ion-content): directive gets its own scope #1392

Closed
wants to merge 1 commit into from

Conversation

xaka
Copy link

@xaka xaka commented May 15, 2014

No description provided.

@xaka
Copy link
Author

xaka commented May 15, 2014

I'm not quite sure that ion-content should have its own scope, but as it is the case right now, people should be warned and aware of that, otherwise they'll debug their code forever :) I'd probably add a documentation section somewhere that would list all directives that get their own scopes.

@ajoslin
Copy link
Contributor

ajoslin commented May 19, 2014

I thought about removing ion-content's child scope before, but for some reason or other did not.

I don't remember why now. I think now it's too late, it would be a breaking change to make ion-content share scope with the parent.

I pushed a fix that notes this, thanks @xaka!

@fredgalvao
Copy link

Now I understand where the ghost bug I had to deal with last week came from!
Thanks for fixing it on the docs though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants