Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (module-loader): remove module from ModuleLoader cache map on promise reject #13663

Closed
wants to merge 238 commits into from
Closed

fix (module-loader): remove module from ModuleLoader cache map on promise reject #13663

wants to merge 238 commits into from

Conversation

longgt
Copy link

@longgt longgt commented Dec 15, 2017

Short description of what this resolves:

Module loader is trying to cache loaded module in map.
After that, when loading page having lazy loading feature, module loader try to get from map instead of loading new for performance reason.
But when module loader failed to loaded lazy chunk (network probs..etc), it should try it again instead of get from map.
On promise reject call back of module loader, remove module from cache.

Ionic Version: 3.x

Fixes: #13639

brandyscarney and others added 30 commits June 12, 2017 13:51
@brandyscarney
style(util): remove commented out test css
a91a68e
@Manduro @manucorporat
fix(refresher): border should only show when pulled (ionic-team#12015)
47e3c70 
fixes ionic-team#10994
@manucorporat
fix(keyboard): big keyboard/input refactor
c10f72b 
fixes ionic-team#9699
fixes ionic-team#11484
fixes ionic-team#11389
fixes ionic-team#11325
fixes ionic-team#11291
fixes ionic-team#10828
fixes ionic-team#11291
fixes ionic-team#10393
fixes ionic-team#10257
fixes ionic-team#9434
fixes ionic-team#8933
fixes ionic-team#7178
fixes ionic-team#7047
fixes ionic-team#10552
fixes ionic-team#10393
fixes ionic-team#10183
fixes ionic-team#10187
fixes ionic-team#10852
fixes ionic-team#11578
@manucorporat
Merge branch 'keyboard-fixes'
6dee17b
@manucorporat
fix(input): add correct translate3d for rtl
ef85ba6 
thanks @Khalid-Nowaf

fixes ionic-team#11745
fixes ionic-team#11211
@Manduro @manucorporat
fix(input): use all supported attributes on both textareas and inputs (…
8041eed 
…ionic-team#12028)
@manucorporat
fix(input): better handling of attributes
9f86e10
@manucorporat
fix(textarea): apply classes properly
dc958c3
@Manduro @manucorporat
fix(input): slightly longer delay for autofocus (ionic-team#12037)
54ac2e3
@danbucholtz
chore(changelog): 3.4.0 release
2791c40
@danbucholtz
chore(dependencies): update package version to 3.4.0
f149c5e
@danbucholtz
chore(github): update issue template plunkr to 3.4.0 version
3564bcf
@manucorporat
fix(input): prevent duplicated tabIndex (ionic-team#12043)
7a1342c 
fixes ionic-team#7178
@manucorporat
refactor(overlay): simplify focusOutActiveElement (ionic-team#12023)
2743c63
@zakton5 @manucorporat
feat(select): add compareWith Input for object value comparison (ioni…
c7645ee 
…c-team#11965)

fixes ionic-team#6625
@manucorporat
fix(highlight): selected tab might be null
5a5da39 
fixes ionic-team#12054
@danbucholtz
chore(changelog): add upgrade instructions for 3.4.0
1a4aacf
@manucorporat
fix(sliding-item): super slow device does get correct classes
6193560 
fixes ionic-team#11988
@AmitMY @manucorporat
feat(item-reorder): add side support (ionic-team#11642)
63f728f 
fixes ionic-team#11637
@manucorporat
perf(item): button-effect is hidden for non buttons
8bd2f24
@manucorporat
style(reorder): using const
7803998
@dudeofawesome @manucorporat
fix(tabs): properly align tabs highlight (ionic-team#11619)
a8731df 
When `Tabs` are nested within each other, the highlight can get
misaligned. This prevents that by ensuring the affected
`.tab-highlight` is a direct child of the targeted `Tabs`.
@danbucholtz
chore(changelog): fix typo, update deps to latest
877d821
@brandyscarney
fix(themes): change default app-direction
1ca7df7
@brandyscarney
chore(ionic): release 3.4.1
5094fee
@brandyscarney
fix(rtl): use multi direction in order to override the default ltr
70b5b6b
@brandyscarney
chore(ionic): release 3.4.2
d8b65da
@manucorporat
fix(select): floating label
e3a8d27 
fixes ionic-team#12068
@danbucholtz
feature(navigation): modify urls to support multiple root level navs/…
5cad965 
…tabs

* wip

* wip

* progress

* wippy skippy

* getting there

* all tests passing except goBack

* unit tests pass again boi

* goBack tests pass

* great success

* the good stuff
@danbucholtz
chore(build): strictly enforce metadata
00fbded
perrygovier and others added 22 commits November 2, 2017 09:55
@perrygovier
chore(CI): ignore CI builds on core for now
d659676
@danbucholtz
feature(dependencies): updates to support angular 5
7c58393 
* chore(dependencies): update to ng5 rc

* chore(dependencies): update for ng 5

* chore(build): remove closure support

* chore(dependencies): fix missing angular/common value
@danbucholtz
chore(build): pass param to app-scripts to avoid reading ionic-angula…
cfdba88 
…r version info within the context of the ionic repo
@danbucholtz
chore(build): remove angular, rxjs, and zone peer deps
4cc54ee
@danielsogl @danbucholtz
refactor(slider-test): HttpClient (ionic-team#13068)
aaa3cac
@danielsogl @danbucholtz
refactor(templates): HttpClient (ionic-team#13067)
efd6605
@danielsogl @danbucholtz
chore(dependencies): update rxjs to 5.5.x
ea71004 
* chore(package): bump rxjs to 5.5

* Update package.json

* Update package.json
@mhartington
fix(tabs): no safe area padding for top tabs
236e7f8
@brandyscarney
fix(action-sheet): move box-shadow to first group
4f3e91b
@danbucholtz
chore(dependencies): revert to ng4 for distribution for now
32c5bed
@danbucholtz
refactor(input): revert input/highlight height change that broke snpa…
75cf887 
…shot
@brandyscarney
fix(datetime): avoid adding cancel and done button repeatedly
248a1ce 
references ionic-team#7333
@danbucholtz
chore(changelog): 3.9.0 changelog
e1948be
@danbucholtz
chore(changelog): 3.9.1 changelog
b224a65
@danbucholtz
chore(changelog): 3.9.1 changelog improvement
5883da2
@brandyscarney
fix(action-sheet): remove ios inertia scroll to fix flicker
c463b06 
fixes ionic-team#13262
@danbucholtz
chore(changelog): 3.9.2 changelog
a7ba5d6
@Dhineshdx @brandyscarney
docs(changelog): add comma in devDependencies (ionic-team#13376)
fed4fd9
@kensodemann
fix(alert): allow disabled text input (ionic-team#13521)
1b3190b 
Fixes: ionic-team#13488
@laurentperroteau @kensodemann
docs(ionPage): add warning about IonicPage Lifecycle (ionic-team#13250)
52c40da
@FdezRomero @mhartington
fix(cordova): don't apply safe area to footer if there are bottom tabs
0182014
fix: remove module from ModuleLoader cache map on promise reject call…
c834138 
… back when loading chunk failed
@codinronan
Copy link

I'd like to see if this can get merged, my metrics show this is happening to every 1 out of 20-30 users which is ALOT more than I would have expected. I'm honestly shocked it can happen at all, network is not necessary to load these chunks since they are already on the device right? So I'm not sure what the root cause is, but I'd like to see if this can help reduce the frequency.

@longgt
Copy link
Author

longgt commented Jan 24, 2018

Ionic Team announced that they are focusing on v4 and there is no any more update will be released on v3.
If you need this pull, fork and merge by yourself instead.

@Ionitron
Copy link
Collaborator

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!

@Ionitron Ionitron closed this Mar 12, 2018
@BAWES
Copy link

BAWES commented Jul 14, 2018

@longgt Does this still work? Any repo where we could pull this to solve our issues?

@longgt
Copy link
Author

longgt commented Jul 16, 2018 •
edited
Loading

@BAWES

You can get it from https://github.com/longgt/ionic, longgt/iss13639 branch.
longgt@c834138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.