Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slide-gesture): RTL fix for slide-gesture #11822

Merged
merged 3 commits into from
Jun 5, 2017

Conversation

sijav
Copy link
Contributor

@sijav sijav commented May 28, 2017

Short description of what this resolves:

RTL fix for slide-gesture, this will resolve any problem with drag from right to left such as swipe to back, items slider, etc.

Changes proposed in this pull request:

  • slide position minus new position instead of new position minus slide position

Ionic Version: 3.x

Fixes: #11211

@sijav
Copy link
Contributor Author

sijav commented May 28, 2017

this commit has a bug on pages with menu, I'll check and fix it.
however this will fix item-sliding directions on touch too

@AmitMY
Copy link
Contributor

AmitMY commented May 28, 2017

@sijav Note that master's menu is buggy, so it might not be your fault.
I have been working on a fix for some time now, but it is not yet perfect, and I am not sure how to perfect it.
Mind having a look? #11336

@sijav
Copy link
Contributor Author

sijav commented May 28, 2017

@AmitMY yes I realize now that it's not my fault but I'm working on it.
I think I know why menu is buggy ...

@sijav
Copy link
Contributor Author

sijav commented May 28, 2017

Menu has been fixed and after this merge and menu fix merge there won't be any bug that I could be aware of.
So if you saw any, just let me know.

@brandyscarney brandyscarney merged commit 59a1e3d into ionic-team:master Jun 5, 2017
@brandyscarney
Copy link
Member

Thank you! 🙂

@sijav
Copy link
Contributor Author

sijav commented Jun 5, 2017

@brandyscarney now that this got merge would you mind check these as well?
#11825 for item sliding
#11830 for menu
Without these item sliding and menu have bugs and won't function correctly
Thank you :)

@sijav sijav deleted the rtl-fix-slide-gesture branch June 5, 2017 18:38
AmitMY pushed a commit to AmitMY/ionic that referenced this pull request Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants