Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Feature Request: maxLength option for $ionicPopup.prompt() #4704

Closed
gregallensworth opened this issue Dec 4, 2015 · 2 comments
Closed

feat: Feature Request: maxLength option for $ionicPopup.prompt() #4704

gregallensworth opened this issue Dec 4, 2015 · 2 comments
Milestone
1.2

Comments

@gregallensworth
Copy link

Type: feat

Platform: all

elements support the maxlength property, which is quite handy if you want to constrain text to only short values, e.g. a nickname. $ionicPopup.prompt() does not have an option to supply a maxLength.
@gregallensworth gregallensworth changed the title Feature Request: maxLength option for $ionicPopup.prompt() feat: Feature Request: maxLength option for $ionicPopup.prompt() Dec 4, 2015
@gregallensworth gregallensworth mentioned this issue Dec 4, 2015
Merged
mlynch added a commit that referenced this issue Dec 6, 2015
@mlynch
Merge pull request #4705 from gregallensworth/master
240cd30 
Feature add for issue #1589 and issue #4704
@mlynch
Copy link
Contributor

mlynch commented Dec 6, 2015

Thanks! Closing since your PR got merged and going to track it there.

@mlynch mlynch closed this as completed Dec 6, 2015
@mlynch mlynch mentioned this issue Dec 6, 2015
Closed
4 tasks
@mlynch mlynch added this to the 1.2 milestone Dec 6, 2015
@HungryJake
Copy link

Still not working? Seems like when I put the maxLength property to 40, it does not affect the input.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
3 participants
@mlynch @HungryJake @gregallensworth