-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First nested tab does not get selected when selecting parent tab #1276
Comments
Hi @ssassi, Your codepen isn't working! |
Sorry, a typo on the link: http://codepen.io/ssassi/pen/djGJB |
I can confirm this: http://codepen.io/niwen/pen/kwvpr |
Yeah. If you click another tab, it works fine. but if you navigate to the first tab, or any other [as long as you just came to this tab container view] using $state.go, it doesn't render the content. The title is updated correctly. |
Confirmed this is still an issue. |
I have also this problem. Even the select function of the tab delegate does not help |
+1 happening for me as well |
I'm trying to help out with some of the leg work on this issue... it's definitely an issue caused by nested tabs, and more specifically, $scope inheritance. The value I'm not sure this is the correct fix, but I was at least able to verify my conclusion by adding this to the top of the If you disagree, I will gladly submit a pull request, but for some reason, it just doesn't quite feel right, and I wasn't able to get it working properly by adding it to any of the link functions, I ran short on time tonight, but perhaps someone more familiar with the framework will have better luck. Please let me know if I can help any other way or if you want further clarification. |
I have the same issue, any one has a solution for this issue ? |
I have a way around this scenario. It's a funny hack actually. On Wed, Dec 3, 2014 at 8:57 AM, harshitgoel96 [email protected]
|
+1 |
I'm freakin out with this issue. Another, inherent problem, is that having a list inside a tab and clicking to a detail view, the back button returns to the first tab, not the tab where the list was. -tab1 would really apreciate some help thanks! |
Fixed in the latest builds. |
The problem exists in current stable release, any timeline to release the new build ? C:\Android Dev\WORKSPACE\blaBla>ionic -v C:\Android Dev\WORKSPACE\blaBla>ionic lib -v |
Just checked nightly 863, still having navigation issues, the first nested tab was loaded porperly, but navigation to second tab still showed the content of first tab, also once the master tab is switched, can not switch back to any other tab structure | |
+1 |
I'm having this problem too! And I'm using the master branch. @adamdbradley is this exptected? |
+1 |
+1 is this landing soon? Merge and define milestone please! |
Like the issue ionic-team#1276 if you have some nested tabs, you select a sub-tab item, and you will active some other siblings, because when tabCtrl add every new $scope, it does't has a initial attr $scope.$tabSelected, so every unselected item will read the $tabSelected from inherited $parent, but if the parent-tab has been actived, the all of its sub-tabs will read this true property in $scope.$tabSelected. So I think we should initialize the property $scope.$tabSelected before invoking tabsCtrl.add(), and every tab-item will has a 'false' status for a initial $scope.$tabSelected.
ok,it's work for me~ |
How would I fix this issue in ionic lib v 1.x (I tried 1.24 and 1.33 with no luck) |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
When using nested tabs I want the first nested tab selected by default.
Please, look at this example: http://codepen.io/ssassi/pen/djGJB2. The first tab's content under home is not rendered when clicking on the Home tab.
The text was updated successfully, but these errors were encountered: