Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ionic g component generates wrong import #11838

Closed
martinlombana opened this issue May 28, 2017 · 3 comments
Closed

Ionic g component generates wrong import #11838

martinlombana opened this issue May 28, 2017 · 3 comments

Comments

@martinlombana
Copy link

Ionic version: (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/driftyco/ionic-v1)
[ ] 2.x
[X ] 3.x

I'm submitting a ... (check one with "x")
[X ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
ionic g component MyComponent
Creates the wrong import inside my-component.module.ts

imports: [
IonicPageModule.forChild(MyComponent),
],

Expected behavior:
The correct import should be:
imports: [
IonicModule,
],

(If you want to provide the ionic module base). But in any case, generating a component should not generate the same import as if it was a page.

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):


global packages:

    @ionic/cli-utils : 1.2.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.2.0

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-cordova       : 1.2.1
    @ionic/cli-plugin-ionic-angular : 1.2.0
    Cordova Platforms               : browser 4.1.0
    Ionic Framework                 : ionic-angular 3.2.1

System:

    Node       : v6.10.3
    OS         : Windows 10
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed
danielsogl added a commit to danielsogl/ionic that referenced this issue May 28, 2017
@danielsogl
refactor(template): fix component template
651e974 
fix ionic-team#11838
@danielsogl danielsogl mentioned this issue May 28, 2017
Merged
@danielsogl
Copy link
Contributor

I created a PR for your issue.

@jgw96 jgw96 closed this as completed in d4fce89 May 30, 2017
@jgw96
Copy link
Contributor

jgw96 commented May 30, 2017 •
edited
Loading

Thanks @danielsogl for fixing this issue!

AmitMY pushed a commit to AmitMY/ionic that referenced this issue May 30, 2017
@danielsogl @AmitMY
refactor(template): fix component template (ionic-team#11839)
fa9762c 
fix ionic-team#11838
brandyscarney pushed a commit that referenced this issue Jun 5, 2017
@AmitMY @brandyscarney
test(snapshot): build all tests into a single app (#11910)
7d8696c 
* fix(lint): unused import

* fix(searchbar): caret moving to the end when typing

* refactor(template): fix component template (#11839)

fix #11838

* chore(issue-template): change link to new org name

* docs(github): rename driftyco references to ionic-team

* fix(toolbar): use the correct contrast color for MD toolbar

fixes #11848

* docs(searchbar): add default values for inputs (#11856)

Complete missing defaults for animated and showCancelButton.

* docs(tabs): rename Angular 2 to Angular (#11837)

* docs(tabs): change double quotes to single quotes (#11836)

* docs(api-tabs): improved typo

* Update tab.ts

* docs(slides): change double quotes to single quotes (#11835)

* docs(api-slides): improve typo

* Update slides.ts

* docs(platform): change double quotes to single quotes (#11834)

* docs(nav-controller): add type to usage example (#11833)

* docs(util): hide normalizeURL (#11735)

* docs(checkbox): rename Angular 2 to Angular (#11831)

* docs(api-checkbox): renamed Angular 2 to Angular

* Update checkbox.ts

* docs(checkbox): improve usage example (#11832)

* docs(api-checkbox): improve typo

* Update chip.ts

* docs(menu): update menu-controller link
Closes #11877. Closes ionic-team/ionic-site#1129

* feat(snapshot): init new "components" for global testing

* feat(snapshot): add app component

* feat(snapshot): add assistive touch

* feat(snapshot): add more components

* feat(snapshot): add more components

* fix(snapshot): add trailing line

* fix(snapshot): remove not working tests

* fix(snapshot): correct name of group
AmitMY added a commit to AmitMY/ionic that referenced this issue Jun 6, 2017
@AmitMY
test(snapshot): build all tests into a single app (ionic-team#11910)
39c9bdb 
* fix(lint): unused import

* fix(searchbar): caret moving to the end when typing

* refactor(template): fix component template (ionic-team#11839)

fix ionic-team#11838

* chore(issue-template): change link to new org name

* docs(github): rename driftyco references to ionic-team

* fix(toolbar): use the correct contrast color for MD toolbar

fixes ionic-team#11848

* docs(searchbar): add default values for inputs (ionic-team#11856)

Complete missing defaults for animated and showCancelButton.

* docs(tabs): rename Angular 2 to Angular (ionic-team#11837)

* docs(tabs): change double quotes to single quotes (ionic-team#11836)

* docs(api-tabs): improved typo

* Update tab.ts

* docs(slides): change double quotes to single quotes (ionic-team#11835)

* docs(api-slides): improve typo

* Update slides.ts

* docs(platform): change double quotes to single quotes (ionic-team#11834)

* docs(nav-controller): add type to usage example (ionic-team#11833)

* docs(util): hide normalizeURL (ionic-team#11735)

* docs(checkbox): rename Angular 2 to Angular (ionic-team#11831)

* docs(api-checkbox): renamed Angular 2 to Angular

* Update checkbox.ts

* docs(checkbox): improve usage example (ionic-team#11832)

* docs(api-checkbox): improve typo

* Update chip.ts

* docs(menu): update menu-controller link
Closes ionic-team#11877. Closes ionic-team/ionic-site#1129

* feat(snapshot): init new "components" for global testing

* feat(snapshot): add app component

* feat(snapshot): add assistive touch

* feat(snapshot): add more components

* feat(snapshot): add more components

* fix(snapshot): add trailing line

* fix(snapshot): remove not working tests

* fix(snapshot): correct name of group
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 2, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgw96 @danielsogl @martinlombana