Skip to content

Commit

Permalink
amend(slidebox): fix typo in 08956b2 Closes #3675, #3589
Browse files Browse the repository at this point in the history
  • Loading branch information
@perrygovier
perrygovier committed May 7, 2015
1 parent d684d62 commit adea328
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/views/sliderView.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ ionic.views.Slider = ionic.views.View.inherit({
element.style.left = '';

// reset slides so no refs are held on to
slides && (slides.length = []);
slides && (slides = []);

// removed event listeners
if (browser.addEventListener) {
Expand Down

1 comment on commit adea328

@2ming
Copy link

@2ming 2ming commented on adea328 Jun 30, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look error!

ionic.bundle.min.js:133 TypeError: Cannot assign to read only property 'length' of object '#<HTMLCollection>'
    at kill (ionic.bundle.min.js:24)
    at ionic.bundle.min.js:387
    at l.$broadcast (ionic.bundle.min.js:159)
    at l.$destroy (ionic.bundle.min.js:155)
    at v (ionic.bundle.min.js:384)
    at Object.cleanup (ionic.bundle.min.js:384)
    at b (ionic.bundle.min.js:384)
    at v (ionic.bundle.min.js:384)
    at ionic.bundle.min.js:169
    at e (ionic.bundle.min.js:71)

"slides.length = []" is error，switch to "slides = []" is ok.
When I don't know what code to merge?

Please sign in to comment.