Skip to content

Commit

Permalink
refactor(scrollController): remove unused dependency
Browse files Browse the repository at this point in the history
also JSLint cleanup
  • Loading branch information
perrygovier committed Feb 25, 2015
1 parent 31fda2f commit 59a0ce8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions js/angular/controller/scrollController.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,14 @@ IonicModule
'$document',
'$ionicScrollDelegate',
'$ionicHistory',
'$controller',
function($scope,
scrollViewOptions,
$timeout,
$window,
$location,
$document,
$ionicScrollDelegate,
$ionicHistory,
$controller) {
$ionicHistory) {

var self = this;
// for testing
Expand Down
4 changes: 2 additions & 2 deletions js/angular/directive/collectionRepeat.js
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ function CollectionRepeatDirective($ionicCollectionManager, $parse, $window, $$r

var withoutQuotes = attrValue.replace(/(\'|\"|px|%)/g, '').trim();
var isConstant = withoutQuotes.length && !/([a-zA-Z]|\$|:|\?)/.test(withoutQuotes);
dimensionData.attrValue = attrValue;;
dimensionData.attrValue = attrValue;

// If it's a constant, it's either a percent or just a constant pixel number.
if (isConstant) {
Expand Down Expand Up @@ -536,7 +536,7 @@ function RepeatManagerFactory($rootScope, $window, $$rAF) {

item = itemsShownMap[i] || (itemsShownMap[i] = itemsLeaving.length ? itemsLeaving.pop() :
itemsPool.length ? itemsPool.shift() :
new RepeatItem())
new RepeatItem());
itemsEntering.push(item);
item.isShown = true;

Expand Down

0 comments on commit 59a0ce8

Please sign in to comment.