fix(content): scroll=false in sidemenu hides content

Closes #1485
ionic-team · Jun 13, 2014 · 53c1710 · 53c1710
1 parent 8da9f34
commit 53c1710
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/demos/directive/sideMenus/navWithMenu/index.html b/demos/directive/sideMenus/navWithMenu/index.html
@@ -19,7 +19,7 @@
       <header class="bar bar-header bar-stable">
         <h1 class="title">Left</h1>
       </header>
-      <ion-content class="has-header">
+      <ion-content class="has-header" scroll="false">
         <ion-list>
           <ion-item nav-clear menu-close href="#/app/search">
             Search

diff --git a/js/angular/directive/content.js b/js/angular/directive/content.js
@@ -58,6 +58,8 @@ function($timeout, $controller, $ionicBind) {
         innerElement = jqLite('<div class="scroll"></div>');
         innerElement.append(element.contents());
         element.append(innerElement);
+      } else {
+        element.addClass('scroll-content-false');
       }
 
       return { pre: prelink };

diff --git a/scss/_scaffolding.scss b/scss/_scaffolding.scss
@@ -69,6 +69,10 @@ body.grade-c {
   height: auto;
 }
 
+.scroll-content-false {
+  z-index: $z-index-scroll-content-false;
+}
+
 .scroll-view {
   position: relative;
   display: block;

diff --git a/scss/_variables.scss b/scss/_variables.scss
@@ -673,10 +673,12 @@ $z-index-modal:                   10 !default;
 $z-index-pane:                    1 !default;
 $z-index-popup:                   12 !default;
 $z-index-scroll-bar:              9999 !default;
+$z-index-scroll-content-false:    10 !default;
 $z-index-slider-pager:            1 !default;
 $z-index-tabs:                    5 !default;
 $z-index-view:                    1 !default;
 
+
 // Platform
 // -------------------------------