Merge pull request #4638 from CasperTech/master

Prevent click events from firing twice on Windows Phone
ionic-team · Dec 6, 2015 · 38a9157 · 38a9157
2 parents 118ba8a + a538035
commit 38a9157
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/js/utils/tap.js b/js/utils/tap.js
@@ -236,6 +236,9 @@ ionic.tap = {
   },
 
   requiresNativeClick: function(ele) {
+    if (ionic.Platform.isWindowsPhone() && (ele.tagName == 'A' || ele.tagName == 'BUTTON' || ele.hasAttribute('ng-click') || (ele.tagName == 'INPUT' && (ele.type == 'button' || ele.type == 'submit')))) {
+      return true; //Windows Phone edge case, prevent ng-click (and similar) events from firing twice on this platform
+    }
     if (!ele || ele.disabled || (/^(file|range)$/i).test(ele.type) || (/^(object|video)$/i).test(ele.tagName) || ionic.tap.isLabelContainingFileInput(ele)) {
       return true;
     }