deprecate native.showkeyboard and native.hidekeyboard

ionic-team · May 19, 2014 · 2d78f93 · 2d78f93
1 parent db43ec6
commit 2d78f93
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/js/angular/directive/keyboardAttach.js b/js/angular/directive/keyboardAttach.js
@@ -21,9 +21,14 @@
 IonicModule
 .directive('keyboardAttach', function() {
   return function(scope, element, attrs) {
+    window.addEventListener('native.keyboardshow', onShow);
+    window.addEventListener('native.keyboardhide', onHide);
+
+    //deprecated
     window.addEventListener('native.showkeyboard', onShow);
     window.addEventListener('native.hidekeyboard', onHide);
 
+
     var scrollCtrl;
 
     function onShow(e) {
@@ -44,6 +49,9 @@ IonicModule
     }
 
     scope.$on('$destroy', function() {
+      window.removeEventListener('native.keyboardshow', onShow);
+      window.removeEventListener('native.keyboardhide', onHide);
+
       window.removeEventListener('native.showkeyboard', onShow);
       window.removeEventListener('native.hidekeyboard', onHide);
     });

diff --git a/js/utils/keyboard.js b/js/utils/keyboard.js
@@ -72,6 +72,10 @@ ionic.keyboard = {
 
 function keyboardInit() {
   if( keyboardHasPlugin() ) {
+    window.addEventListener('native.keyboardshow', keyboardNativeShow);
+    window.addEventListener('native.keyboardhide', keyboardFocusOut);
+
+    //deprecated
     window.addEventListener('native.showkeyboard', keyboardNativeShow);
     window.addEventListener('native.hidekeyboard', keyboardFocusOut);
   }
@@ -297,6 +301,7 @@ function keyboardHasPlugin() {
 }
 
 ionic.Platform.ready(function() {
+  ionic.Platform.isFullScreen = true;
   keyboardUpdateViewportHeight();
 
   // Android sometimes reports bad innerHeight on window.load