Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Commit

Permalink
fix(config): node_modules directory should not be configurable (users…
Browse files Browse the repository at this point in the history
… were finding it confusing)
  • Loading branch information
danbucholtz committed Feb 15, 2017
1 parent 79b0eeb commit 1f58aaa
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ npm run build --rollup ./config/rollup.config.js
| www directory | `ionic_www_dir` | `--wwwDir` | `www` | The deployable directory containing everything needed to run the app |
| build directory | `ionic_build_dir` | `--buildDir` | `build` | The build process uses this directory to store generated files, etc |
| temp directory | `ionic_tmp_dir` | `--tmpDir` | `.tmp` | Temporary directory for writing files for debugging and various build tasks |
| node_modules directory | `ionic_node_modules_dir` | `--nodeModulesDir` | `node_modules` | Node modules directory |
| ionic-angular directory | `ionic_angular_dir` | `--ionicAngularDir` | `ionic-angular` | ionic-angular directory |
| ionic-angular entry point | `ionic_angular_entry_point` | `--ionicAngularEntryPoint` | `index.js` | entry point file for ionic-angular |
| bundler | `ionic_bundler` | `--bundler` | `webpack` | Chooses which bundler to use: `webpack` or `rollup` |
Expand Down
2 changes: 1 addition & 1 deletion src/util/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export function generateContext(context?: BuildContext): BuildContext {
setProcessEnvVar(Constants.ENV_VAR_BUILD_DIR, context.buildDir);
Logger.debug(`buildDir set to ${context.buildDir}`);

context.nodeModulesDir = resolve(context.nodeModulesDir || getConfigValue(context, '--nodeModulesDir', null, Constants.ENV_VAR_NODE_MODULES_DIR, Constants.ENV_VAR_NODE_MODULES_DIR.toLowerCase(), join(context.rootDir, Constants.NODE_MODULES)));
context.nodeModulesDir = join(context.rootDir, Constants.NODE_MODULES);
setProcessEnvVar(Constants.ENV_VAR_NODE_MODULES_DIR, context.nodeModulesDir);
Logger.debug(`nodeModulesDir set to ${context.nodeModulesDir}`);

Expand Down

0 comments on commit 1f58aaa

Please sign in to comment.