fix(ios): no space left on device

ionic-team · Sep 23, 2022 · fc254fe · fc254fe
1 parent 3afcf14
commit fc254fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 Changelog
 ======
+## 5.5.3
+* Fixed iOS "no space left on device"
+
 ## 5.5.2
 * Fixed iOS error 28 – no space left on device
 

diff --git a/src/ios/IonicCordovaCommon.m b/src/ios/IonicCordovaCommon.m
@@ -72,8 +72,7 @@ - (void) downloadFile:(CDVInvokedUrlCommand*)command {
     NSLog(@"Got downloadFile: %@", options);
 
     NSURLRequest *request = [NSURLRequest requestWithURL:[NSURL URLWithString:urlStr]];
-    NSURLSession *urlSession = [NSURLSession sessionWithConfiguration:[NSURLSessionConfiguration defaultSessionConfiguration]];
-    [[urlSession dataTaskWithRequest:request completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
+    [[[NSURLSession sharedSession] dataTaskWithRequest:request completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
         if (error) {
             NSLog(@"Download Error:%@",error.description);
             [self.commandDelegate sendPluginResult:[CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString: [error localizedDescription]]  callbackId:command.callbackId];
@@ -90,14 +89,6 @@ - (void) downloadFile:(CDVInvokedUrlCommand*)command {
             NSLog(@"File is saved to %@", target);
             [self.commandDelegate sendPluginResult:[CDVPluginResult resultWithStatus:CDVCommandStatus_OK] callbackId:command.callbackId];
         }
-
-        // When numerous downloads are called the sessions are not always invalidated and cleared by iOS14.
-        // This leads to error 28 – no space left on device so we manually flush and invalidate to free up space
-        if(urlSession != nil) {
-            [urlSession flushWithCompletionHandler:^{
-                [urlSession finishTasksAndInvalidate];
-            }];
-        }
     }] resume];
 }