chore(cli): fix unused warnings (#3625)

ionic-team · Sep 29, 2020 · d5b1631 · d5b1631
1 parent 0248fd1
commit d5b1631
Show file tree

Hide file tree

Showing 12 changed files with 12 additions and 50 deletions.
diff --git a/cli/src/common.ts b/cli/src/common.ts
@@ -13,7 +13,6 @@ import xml2js from 'xml2js';
 import c from './colors';
 import type { Config, PackageJson, ExternalConfig } from './definitions';
 import { output, logger } from './log';
-import { emoji as _e } from './util/emoji';
 import { copyAsync, existsAsync, readFileAsync, renameAsync } from './util/fs';
 
 export type CheckFunction = () => Promise<string | null>;
@@ -60,7 +59,7 @@ export async function checkWebDir(config: Config): Promise<string | null> {
   return null;
 }
 
-export async function checkPackage(_config: Config): Promise<string | null> {
+export async function checkPackage(): Promise<string | null> {
   if (!(await existsAsync('package.json'))) {
     return (
       `The Capacitor CLI needs to run at the root of an npm package.\n` +
@@ -185,7 +184,7 @@ export function parseXML(xmlStr: string): any {
 }
 
 export async function writeXML(object: any): Promise<any> {
-  return new Promise((resolve, reject) => {
+  return new Promise(resolve => {
     const builder = new xml2js.Builder({
       headless: true,
       explicitRoot: false,

diff --git a/cli/src/index.ts b/cli/src/index.ts
@@ -30,7 +30,7 @@ export async function run(): Promise<void> {
     .command('create [directory] [name] [id]', { hidden: true })
     .description('Creates a new Capacitor project')
     .action(() => {
-      return createCommand(config);
+      return createCommand();
     });
 
   program
@@ -48,7 +48,7 @@ export async function run(): Promise<void> {
     .command('serve', { hidden: true })
     .description('Serves a Capacitor Progressive Web App in the browser')
     .action(() => {
-      return serveCommand(config);
+      return serveCommand();
     });
 
   program
@@ -114,7 +114,7 @@ export async function run(): Promise<void> {
     .command('plugin:generate', { hidden: true })
     .description('start a new Capacitor plugin')
     .action(() => {
-      return newPluginCommand(config);
+      return newPluginCommand();
     });
 
   program.arguments('[command]').action(cmd => {

diff --git a/cli/src/ios/add.ts b/cli/src/ios/add.ts
@@ -1,5 +1,3 @@
-import { relative } from 'path';
-
 import c from '../colors';
 import { copyTemplate, runTask } from '../common';
 import type { Config } from '../definitions';

diff --git a/cli/src/tasks/add.ts b/cli/src/tasks/add.ts
@@ -78,7 +78,7 @@ export async function addCommand(
 
     try {
       await check([
-        () => checkPackage(config),
+        () => checkPackage(),
         () => checkAppConfig(config),
         ...addChecks(config, platformName),
       ]);

diff --git a/cli/src/tasks/create.ts b/cli/src/tasks/create.ts
@@ -1,8 +1,7 @@
 import c from '../colors';
 import { logFatal } from '../common';
-import type { Config } from '../definitions';
 
-export async function createCommand(config: Config): Promise<void> {
+export async function createCommand(): Promise<void> {
   logFatal(
     `The create command has been removed.\n` +
       `Use ${c.input('npm init @capacitor/app')}`,

diff --git a/cli/src/tasks/init.ts b/cli/src/tasks/init.ts
@@ -12,7 +12,6 @@ import {
 import { getCordovaPreferences } from '../cordova';
 import type { Config } from '../definitions';
 import { output } from '../log';
-import { emoji as _e } from '../util/emoji';
 import { checkInteractive, isInteractive } from '../util/term';
 
 export async function initCommand(

diff --git a/cli/src/tasks/new-plugin.ts b/cli/src/tasks/new-plugin.ts
@@ -1,8 +1,7 @@
 import c from '../colors';
 import { logFatal } from '../common';
-import type { Config } from '../definitions';
 
-export async function newPluginCommand(config: Config): Promise<void> {
+export async function newPluginCommand(): Promise<void> {
   logFatal(
     `The plugin:generate command has been removed.\n` +
       `Use ${c.input('npm init @capacitor/plugin')}`,

diff --git a/cli/src/tasks/serve.ts b/cli/src/tasks/serve.ts
@@ -1,8 +1,7 @@
 import c from '../colors';
 import { logFatal } from '../common';
-import type { Config } from '../definitions';
 
-export async function serveCommand(config: Config): Promise<void> {
+export async function serveCommand(): Promise<void> {
   logFatal(
     `The serve command has been removed.\n` +
       `Use a third-party tool for serving single page apps, such as ${c.strong(

diff --git a/cli/src/tasks/sync.ts b/cli/src/tasks/sync.ts
@@ -41,7 +41,7 @@ export async function syncCommand(
     }
     try {
       await check([
-        () => checkPackage(config),
+        () => checkPackage(),
         () => checkWebDir(config),
         ...updateChecks(config, platforms),
       ]);

diff --git a/cli/src/tasks/update.ts b/cli/src/tasks/update.ts
@@ -40,10 +40,7 @@ export async function updateCommand(
       return;
     }
     try {
-      await check([
-        () => checkPackage(config),
-        ...updateChecks(config, platforms),
-      ]);
+      await check([() => checkPackage(), ...updateChecks(config, platforms)]);
 
       await allSerial(
         platforms.map(platformName => async () =>

diff --git a/cli/src/util/fs.ts b/cli/src/util/fs.ts
@@ -24,7 +24,7 @@ export const readFileSync = fsExtra.readFileSync;
 export const writeFileSync = fsExtra.writeFileSync;
 export const existsAsync = async (path: string): Promise<boolean> => {
   try {
-    const stat = await statAsync(path);
+    await statAsync(path);
     return true;
   } catch {
     return false;

diff --git a/cli/test/util.ts b/cli/test/util.ts
@@ -189,34 +189,6 @@ const CORDOVA_PLUGIN_PACKAGE = `
 }
 `;
 
-const CORDOVA_PLUGINS_RESOURCES_PODSPEC = `
-Pod::Spec.new do |s|
-  s.name = 'CordovaPluginsResources'
-  s.version = '0.0.105'
-  s.summary = 'Resources for Cordova plugins'
-  s.social_media_url = 'https://twitter.com/capacitorjs'
-  s.license = 'MIT'
-  s.homepage = 'https://capacitorjs.com/'
-  s.authors = { 'Ionic Team' => '[email protected]' }
-  s.source = { :git => 'https://github.com/ionic-team/capacitor.git', :tag => s.version.to_s }
-  s.resources = ['resources/*']
-end
-`;
-
-const CORDOVA_PLUGINS_PODSPEC = `
-Pod::Spec.new do |s|
-  s.name = 'CordovaPlugins'
-  s.version = '0.0.105'
-  s.summary = 'Autogenerated spec'
-  s.license = 'Unknown'
-  s.homepage = 'https://example.com'
-  s.authors = { 'Capacitor Generator' => '[email protected]' }
-  s.source = { :git => 'https://github.com/ionic-team/does-not-exist.git', :tag => s.version.to_s }
-  s.source_files = 'sources/**/*.{swift,h,m,c,cc,mm}'
-  s.ios.deployment_target  = '10'
-  s.dependency 'CapacitorCordova'
-end`;
-
 async function makeCordovaPlugin(cordovaPluginPath: string) {
   const iosPath = join(cordovaPluginPath, 'src', 'ios');
   const androidPath = join(cordovaPluginPath, 'android/com/getcapacitor');