feat: support angular 18 #513
Merged
+1,892
−767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
suggested changes
Sep 3, 2024
There was a problem hiding this comment.
Can you please add a brief PR description to what you changed and why (high level is fine), to help with any future archeology a developer may make to identify why code changed to support Angular 18?
e.g.:
- Updated Angular dependencies to support compilation against Angular 18
- Updated lint-staged and copy-webpack-plugin because "insert reasoning"
sean-perkins
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Changes look good to me. I appreciate the contribution here!
I haven't approved a PR here since my permissions were adjusted, so if I need to get another approval for merge, I will notify the internal team. Otherwise we can move forward with a merge & release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR several components have been updated, but the most importent change is that the dependencies of the 2 packages(cordova-builders and schematics) have been updated to Angular 18.
also: