Template fix: missing entry point if "argparse" and config for "nosetests" #64
Conversation
… 'no' and not only for 'plain' or 'click' ('argparse' was missing).
…``tox.ini``. ``pytest`` is removed from ``setup.cfg`` if ``nose`` is chosen.
| @@ -65,10 +65,10 @@ commands = | |||
| {%- endif %} | |||
| {%- else %} | |||
| {%- if cookiecutter.test_matrix_separate_coverage|lower == 'yes' %} | |||
| nocov: {posargs:nosetests -v tests} | |||
There was a problem hiding this comment.
This needs not be removed: it would collect the code in the src dir while normally it's imported from site-packages. That would lead to many subtle issues(like doubly executed module, reference issues, collection errors etc).
There was a problem hiding this comment.
Hmmm... on second thought, does the [nosetests]where in setup.cfg always apply?
There was a problem hiding this comment.
I fact nosetes read the setup.cfg if it is started in the project's directory.
See: http://nose.readthedocs.io/en/latest/usage.html#configuration
Is the current working directory set during tox task?
There was a problem hiding this comment.
CWD isn't changed. It's fine, however, if the location is fixed in the config file then the cover envs have no chance of collecting doctests. This is why it was specified on command line. Less than ideal but test_matrix_separate_coverage is not for everyone either :)
|
Good catch about that missing entrypoint. I wonder if the default tests should be integration tests (the missing entrypoint would had been caught early) ... |
I change the
setup.pyto generate the console script entry point in "argparse" is chosen (not only "plain" or "click").I add a section for
nosetestsinsetup.cfgif "nose" if chosen and remove thepytestsection.I fix the
nosetestscommand intox.ini: "tests" is removed because it is interpreted as being a package instead of a directory.