Add GNU LGPL licenses. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for GNU LGPL v3 (or later), or v2 (or later) to the license options. Note that GNU GPLv3 is an add-on to the GNU GPLv3, so the LICENSE file includes both licenses in this case. GNU licensing guidelines (see: https://www.gnu.org/licenses/gpl-howto.html) recommend placing a copyright and license notice at the top of every file; to keep consistency with how the other licenses are implemented in `cookiecutter-pylibrary`, we put such a notice at the top of the `LICENSE` file only.
|
Note: this adds support for the GNU Lesser GPL, so it's not the same as #89 |
ionelmc
reviewed
Mar 31, 2020
{{cookiecutter.repo_name}}/setup.py
Outdated
| @@ -103,7 +103,12 @@ def _unavailable(self, e): | |||
| "BSD 3-Clause License": "BSD-3-Clause", | |||
| "MIT license": "MIT", | |||
| "ISC license": "ISC", | |||
| "Apache Software License 2.0": "Apache-2.0"}[cookiecutter.license] | |||
| "Apache Software License 2.0": "Apache-2.0", | |||
| "GNU Lesser General Public License v3 or later (LGPLv3+)": "GNU Lesser General Public License v3 or later (LGPLv3+)", | |||
There was a problem hiding this comment.
This mapping here exists to map the displayed license (what the user sees when cookiecutter is used) to a a spdx complying identifier. See https://spdx.org/licenses/
There was a problem hiding this comment.
Thanks for the explanation! Fixed in c783640
There was a problem hiding this comment.
Also, forgot to mention, it needs to be spdx because tidelift and I suspect other systems too use that standard to get license metadata (as opposed to the license classifiers that are already standardized in python, sadly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for GNU LGPL v3 (or later), or v2 (or later)
to the license options.
Note that GNU LGPLv3 is an add-on to the GNU GPLv3, so the LICENSE file
includes both licenses in this case.
GNU licensing guidelines (see: https://www.gnu.org/licenses/gpl-howto.html)
recommend placing a copyright and license notice at the top of every
file; to keep consistency with how the other licenses are implemented
in
cookiecutter-pylibrary, we put such a notice at the top of theLICENSEfile only.