-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warning of setup.py check
#109
base: master
Are you sure you want to change the base?
Fix deprecation warning of setup.py check
#109
Conversation
e6d486c
to
a7294c6
Compare
This always gives an error after you've produced the doc in dist/docs, right?
|
…to fix_deprecation_warning_setup_py_check
Yeah dist/docs is a problem. I wish there was another way of doing this. Twine, an upload tool, is the wrong place to do this check. |
Either way, even if twine could be the right tool the check env is not meant to build dists, and twine check would only test one of the dists - which is inadequate. To really solve this pylibrary needs a way to automate publishing (and then piggyback twine check on top of that). |
Btw it was deprecated in this ninja change: pypa/readme_renderer#122 - devoid of any discussion or explanation. |
This is still on my todo list. Just need to figure out a clean way do do it cross-platform (like using some tmp dir) without mucking about in the dist folder which might have other dists there. |
You could always specify a file extension pattern, and then it will work (with ignoring docs) ... |
Inspired by how it got fixed in pyca/cryptography#4523
Fixes #108