Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #94

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Update setup.py #94

merged 7 commits into from
Aug 6, 2024

Conversation

niekdejonge
Copy link
Collaborator

The removal of add_losses leads to some breaking changes for matchms. (in tutorial and some tests)
These changes are fixed to make spec2vec compatible with 0.27.0 again in #93, but since this needs some more fixes and code review this temporary fix will be implemented.

Copy link

sonarqubecloud bot commented Aug 6, 2024

@niekdejonge
Copy link
Collaborator Author

@florian-huber Some unrelated tests are failing, if I remember correctly you solved this before for matchms. Something with syntax errors in the readme for python 3.9.

@niekdejonge niekdejonge merged commit 7da1872 into master Aug 6, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant