Fixes centering of Help and Play icons in header in some browsers by removing padding (#2567) #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2570 +/- ##
==========================================
+ Coverage 71.05% 71.23% +0.18%
==========================================
Files 239 239
Lines 5876 5883 +7
Branches 937 940 +3
==========================================
+ Hits 4175 4191 +16
+ Misses 1684 1675 -9
Partials 17 17
|
wlach
suggested changes
Dec 18, 2019
There was a problem hiding this comment.
Hi @Samrose-Ahmed! Thanks for this. This works fine, but I think it would be better to override the class menu-button with this change:
Something like padding: 0 !important; should do the trick.
Also, can you add a quick note to CHANGELOG.md about this change? The PR title should be fine.
Bumps [django](https://github.com/django/django) from 3.0 to 3.0.1. - [Release notes](https://github.com/django/django/releases) - [Commits](django/django@3.0...3.0.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
…#2577) Bumps [responses](https://github.com/getsentry/responses) from 0.10.8 to 0.10.9. - [Release notes](https://github.com/getsentry/responses/releases) - [Changelog](https://github.com/getsentry/responses/blob/master/CHANGES) - [Commits](getsentry/responses@0.10.8...0.10.9) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [coverage](https://github.com/nedbat/coveragepy) from 5.0 to 5.0.1. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@coverage-5.0...coverage-5.0.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
…ject#2587) Bumps [regex](https://bitbucket.org/mrabarnett/mrab-regex) from 2019.12.19 to 2019.12.20. - [Commits](https://bitbucket.org/mrabarnett/mrab-regex/commits) Signed-off-by: dependabot-preview[bot] <[email protected]>
…into header-icon-center
wlach
reviewed
Dec 30, 2019
| @@ -1,7 +1,11 @@ | |||
| # (Unreleased; add upcoming change notes here) | |||
| - Fixes centering of Help and Play icons in header in some browsers by removing padding (#2567) | |||
There was a problem hiding this comment.
Suggested change
| - Fixes centering of Help and Play icons in header in some browsers by removing padding (#2567) | |
| - Center "Help" and "Play" icons in some browsers (fixes #2567) (#2570) |
|
This looks good, minus some wording nits in the changelog. I will merge, and adjust the changelog after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers were out of center due to padding being applied by Button component. Set padding to 0px to fix.
Pull Request checklist