Better onboarding flow for running notebook #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also has the fun side-effect of showing off our github emoji support, which doesn't seem to be frequently used.
For the cases where it is likely a user might not have used iodide before, provide some helpful text suggesting they press the fast forward button to execute a notebook.
wlach
force-pushed
the
better-onboarding-flow-for-running-notebook
branch
from
cde8dc6
to
ed35c64
Compare
Codecov Report
@@ Coverage Diff @@
## master #2471 +/- ##
==========================================
+ Coverage 60.17% 69.69% +9.51%
==========================================
Files 172 223 +51
Lines 3890 5490 +1600
Branches 776 884 +108
==========================================
+ Hits 2341 3826 +1485
- Misses 1549 1645 +96
- Partials 0 19 +19
|
bcolloran
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the things I've noticed when trying to onboard people onto iodide in the last few months
is that the use of the "fast forward" button when they first go to a notebook is not necessarily intuitive. To improve things here, include some explanatory text in both the new notebook template (this also has the convenient side-effect of demonstrating how to use emoji's) as well as the header messages about its use.
Pull Request checklist