Use webpack production mode for building iodide (fixes #2023) #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2023) Also, use terser-js (uglify doesn't support some ES6 constructs we now use). This shaves over a megabyte off of the uncompressed file sizes for our js bundles.
Codecov Report
@@ Coverage Diff @@
## master #2402 +/- ##
=======================================
Coverage 69.51% 69.51%
=======================================
Files 223 223
Lines 5451 5451
Branches 877 877
=======================================
Hits 3789 3789
Misses 1643 1643
Partials 19 19 |
|
I noticed other problems and cruft in our webpack config while doing this (e.g. our use of a ".dev" postfix on all our files is no longer necessary), but I'll file those as separate PRs after this lands in the interests of keeping things easy-to-review. |
|
Got a verbal r+ from @bcolloran, gonna merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use terser-js (uglify doesn't support some ES6 constructs we now use).
This shaves over a megabyte off of the uncompressed file sizes for our
js bundles.