Check for common.licenseInformation

[klein0r]

• io pack test should check for common.licenseInformationinstead of `common.license #592

[klein0r]

Like this @foxriver76 ?

[foxriver76]

LGTM, but will of course fail if new attribute not provided, but if someone touches adapter should not hurt.

Question is if this is used by RepoChecker, then it would be annoying, because not urgent @mcm1957 do you know details?

[klein0r]

but will of course fail if new attribute not provided

Like the schema check for io-package in my IDE 😄

[mcm1957]

@AlCalzone
PLEASE DO NOT MERGE in this variant

The check MUST NOT fail if new attribute is missing.
The check MUST pass if EITHER license OR licenseInformation (and possible both of them) are present.

Otherwise every dependabot PR will fail for older adapters.
And every small change will cause the tests to fail.
I will not be able to releases without additional effort new versions as tests will fail.

@Apollon77
As far as I remember the discussion yesterday devs MUST NOT Be forced to adapt io-package.json in the very near future as this has no benefit for free adapters at all and will only cause devs to be frustrated.

[mcm1957]

LGTM, but will of course fail if new attribute not provided, but if someone touches adapter should not hurt.

Question is if this is used by RepoChecker, then it would be annoying, because not urgent @mcm1957 do you know details?

This test is used at GITHUB actions only.
This test MUST acceot old license attribute too, current change is to restrictive.

Repochecker is completly independent.
Repochecker must accpet old and new syntax too, a warnig if license is used is OK. No error must be issued.

[klein0r]

The check MUST NOT fail if new attribute is missing. The check MUST pass if EITHER license OR licenseInformation (and possible both of them) are present.

In that case the schema should also be valid if one of the attributes is configured. At the moment licenseInformation is a required attribute and my IDE complains about the missing attribute... So I've changed it and removed the deprecated attribute.

Now all tests of all my adapters fail and I provided this PR which matches the schema of io-package (removed a deprecated attribute and check for the required attribute)...

[klein0r]

In my opinion the schema is the leading instance here and all other processes (create-adapter, repochecker, testing, ...) have to follow that definition.

[AlCalzone]

This would break tests for all existing adapters - unlike the schema check in VSCode, which you can choose to ignore.

Until license is removed from js-controller or admin, we should enforce that at least one of license or licenseInformation exists.

create-adapter can be stricter, since it is used for new adapters.
IMO the repo-checker should only warn for now and guide devs to migrating from license to licenseInformation.

[klein0r]

Ok then I'll wait for the official solution

[AlCalzone]

Happy to merge your PR if you modify it :)
That will probably be quicker than doing it myself.