Check common.licenseInformation, common.tier, common.automaticUpgrade

[klein0r]

• Added check for licenseInformation
• Added check for required attribute common.tier
• Added check for required attribute common.automaticUpgrade

[mcm1957]

Line 2021 (

ioBroker.repochecker/index.js

Line 2021 in d24e78d

let repoUrl = 'https://github.com/klein0r/ioBroker.luftdaten';

)
seems to be corrupt:

let repoUrl = 'https://github.com/klein0r/ioBroker.luftdaten';

Repo Checker MIUST not check anything not yet provided by adapter creator - at least not at level ERROR.

[mcm1957]

Additional question:
Where are the new attributes documented ?
How is it planned to inform developers ?

[klein0r]

Where are the new attributes documented ?

Just in the schema - so your IDE should help you to remove those warnings:

• https://github.com/ioBroker/ioBroker.js-controller/blob/c45cf0b5150f4268f4250635490d330a8caab541/schemas/io-package.json#L833-L879
• https://github.com/ioBroker/ioBroker.js-controller/blob/c45cf0b5150f4268f4250635490d330a8caab541/schemas/io-package.json#L776-L785

Repo Checker MIUST not check anything not yet provided by adapter creator

Okay, but those attributes (like licenseInformation) are marked as required in the official schema. So my IDE complains about missing tier or licenseInformation.

[klein0r]

licenseInformation is already included in create-adapter: ioBroker/create-adapter#1092

[Apollon77]

mybwe lets use warnings for now? in fact repo is built in a backward compatible way

[klein0r]

I've just updated the existing error message for the new attribute (which was also an error):

ioBroker.repochecker/index.js

Lines 874 to 876 in e81d359

	if (!context.ioPackageJson.common.license) {
	context.errors.push('[E115] No license found in io-package.json');
	} else {

[mcm1957]

licenseInformation is already included in create-adapter: ioBroker/create-adapter#1092

What about [common.automaticUpgrade] ?
I think this attribute is not even useful at the moment.

[klein0r]

What about tier and

https://github.com/ioBroker/ioBroker.js-controller/blob/master/README.md#tiers-start-instances-in-an-ordered-manner

tier defaults to 3 in create-adapter: https://github.com/ioBroker/create-adapter/blob/985c68b54ab530476687c755d5d5fc775de48b10/templates/io-package.json.ts#L99

What about [common.automaticUpgrade] ?

See PR. It's a js-controller 5.1 feature and just validated. There is no error or warning if nothing is defined.

[Apollon77]

@klein0r We discussed today in Dev Meeting: automaticUpgrade should be validated as "not included" from developer side. This field is just set by the User via Admin ... So yes it is formally part of the schema, but irrelevant for the developer.

Default tier schould be 2 in my eyes