Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to mark devices or bridged devices as "errornous" in UI for user to check #198

Closed
Apollon77 opened this issue Dec 5, 2024 · 5 comments
Assignees
Labels
backend/matter issue is relevant for backend/matter enhancement New feature or request

Comments

@Apollon77
Copy link
Collaborator

as followup to #194 it would be the best if we can enhance the error handling in the following way:

  • In case of an error the backend updates the relevant object and disables the device or bridged device and sets a special "checkNeeded/error" flag mor as text containing the error mesage
  • The UI will display the "error" as an icon (maybe red triangle or such) with infos to the user, so that the user can fix the issue before re-enabling it.
@Apollon77 Apollon77 added enhancement New feature or request frontend/ui issue is relevant for matter adapter frontend/ui labels Dec 5, 2024
@GermanBluefox GermanBluefox added the fixed issue is fixed and can be retested label Dec 11, 2024
@GermanBluefox GermanBluefox added backend/matter issue is relevant for backend/matter and removed frontend/ui issue is relevant for matter adapter frontend/ui fixed issue is fixed and can be retested labels Dec 11, 2024
Apollon77 pushed a commit that referenced this issue Dec 12, 2024
#223)

* Added extended dialog: #181
Added ioBroker vendor icon: #192
Changed some texts: #168
Make info closable
Make it possible to show always qr-code: #138

* Make contrast icons: #187

* Make dialog wider: #190

* Change info boxes

* Show warning icon if device is in erroneous mode: #198

* Made waiting time 5 minutes: #185

* Implemented progress dialog: #199

* Fixing pipeline

* Fixing pipeline

* Fixing pipeline
@Apollon77 Apollon77 added the fixed issue is fixed and can be retested label Dec 17, 2024
@Feuer-sturm
Copy link
Collaborator

Feuer-sturm commented Dec 26, 2024

matter 0.3.2

@GermanBluefox No popup is shown after clicking on the red icon
grafik

steps to reproduce

  • ioBroker device created and ioBroker Matter Device created on its basis
  • ioBroker device deleted -> no reaction in the Device tab, not even with F5 (will be followed up in issue Allow to mark devices or bridged devices as "errornous" in UI for user to check during runtime #256)
  • Matter Device deactivated and reactivated -> error in the tab (ok), new icon directly visible without page refres ( not ok 🔴 ), new icon visible after page refresh (ok 🟢 ), but when you click on the red icon no popup appears (not ok 🔴 )

Log

message(6).txt

Log during clicking on the red icon

2024-12-27 00:02:05.088 - debug: matter.0 (1188) 2024-12-27 00:02:05.088 DEBUG ServerSubscription Sending subscription update message for ID 2152996643 with 0 attributes and 0 events
2024-12-27 00:02:05.088 - debug: matter.0 (1188) 2024-12-27 00:02:05.088 DEBUG MessageExchange New exchange channel: udp://fe80::16b3:e2c8:3a53:14e0%ens18:5540 on session secure/29772 protocol: 1 id: 22940 session: secure/29772 peerSessionId: 29647 active threshold ms: 4000 active interval ms: 300 idle interval ms: 500 maxTransmissions: 5 useMrp: true
2024-12-27 00:02:05.088 - debug: matter.0 (1188) 2024-12-27 00:02:05.088 DEBUG InteractionMessenger Sending DataReport chunk with 0 attributes and 0 events: 13 bytes (moreChunkedMessages: false, suppressResponse: true)
2024-12-27 00:02:05.090 - debug: matter.0 (1188) 2024-12-27 00:02:05.090 DEBUG ExchangeManager Message » id: 29647/22940/138460761 type: 1/5 acked: undefined reqAck: true duplicate: false payload: 152600231f5480290424ff0c18
2024-12-27 00:02:05.095 - debug: matter.0 (1188) 2024-12-27 00:02:05.095 DEBUG MessageExchange Message « id: 29772/22940/202002904 type: 0/16 acked: 138460761 reqAck: false duplicate: false payload:
2024-12-27 00:02:07.121 - debug: matter.0 (1188) Handle message deviceExtendedInfo {"command":"deviceExtendedInfo","message":{"uuid":"eddc07d3-d34b-4887-a1df-03c6f944bf12"},"from":"system.adapter.admin.0","callback":{"message":{"uuid":"eddc07d3-d34b-4887-a1df-03c6f944bf12"},"id":180,"ack":false,"time":1735254127120},"_id":33822253}
2024-12-27 00:02:07.352 - debug: matter.0 (1188) 2024-12-27 00:02:07.351 DEBUG ServerSubscription Sending subscription update message for ID 1743628247 with 0 attributes and 0 events
2024-12-27 00:02:07.352 - debug: matter.0 (1188) 2024-12-27 00:02:07.352 DEBUG MessageExchange New exchange channel: udp://fe80::16b3:e2c8:3a53:14e0%ens18:5540 on session secure/61738 protocol: 1 id: 26278 session: secure/61738 peerSessionId: 29644 active threshold ms: 4000 active interval ms: 300 idle interval ms: 500 maxTransmissions: 5 useMrp: true
2024-12-27 00:02:07.353 - debug: matter.0 (1188) 2024-12-27 00:02:07.353 DEBUG InteractionMessenger Sending DataReport chunk with 0 attributes and 0 events: 13 bytes (moreChunkedMessages: false, suppressResponse: true)
2024-12-27 00:02:07.353 - debug: matter.0 (1188) 2024-12-27 00:02:07.353 DEBUG ExchangeManager Message » id: 29644/26278/228007792 type: 1/5 acked: undefined reqAck: true duplicate: false payload: 152600d7a7ed67290424ff0c18
2024-12-27 00:02:07.359 - debug: matter.0 (1188) 2024-12-27 00:02:07.359 DEBUG MessageExchange Message « id: 61738/26278/93938981 type: 0/16 acked: 228007792 reqAck: false duplicate: false payload:
2024-12-27 00:02:11.395 - debug: matter.0 (1188) 2024-12-27 00:02:11.395 DEBUG ServerSubscription Sending subscription update message for ID 4060187233 with 0 attributes and 0 events
2024-12-27 00:02:11.395 - debug: matter.0 (1188) 2024-12-27 00:02:11.395 DEBUG MessageExchange New exchange channel: udp://fe80::16b3:e2c8:3a53:14e0%ens18:5540 on session secure/42328 protocol: 1 id: 56910 session: secure/42328 peerSessionId: 29650 active threshold ms: 4000 active interval ms: 300 idle interval ms: 500 maxTransmissions: 5 useMrp: true
2024-12-27 00:02:11.396 - debug: matter.0 (1188) 2024-12-27 00:02:11.396 DEBUG InteractionMessenger Sending DataReport chunk with 0 attributes and 0 events: 13 bytes (moreChunkedMessages: false, suppressResponse: true)
2024-12-27 00:02:11.396 - debug: matter.0 (1188) 2024-12-27 00:02:11.396 DEBUG ExchangeManager Message » id: 29650/56910/75761521 type: 1/5 acked: undefined reqAck: true duplicate: false payload: 152600618a01f2290424ff0c18
2024-12-27 00:02:11.402 - debug: matter.0 (1188) 2024-12-27 00:02:11.402 DEBUG MessageExchange Message « id: 42328/56910/102000480 type: 0/16 acked: 75761521 reqAck: false duplicate: false payload:
2024-12-27 00:02:14.178 - debug: matter.0 (1188) 2024-12-27 00:02:14.178 DEBUG ServerSubscription Sending subscription update message for ID 4172185760 with 0 attributes and 0 events
2024-12-27 00:02:14.179 - debug: matter.0 (1188) 2024-12-27 00:02:14.179 DEBUG MessageExchange New exchange channel: udp://fe80::16b3:e2c8:3a53:14e0%ens18:5540 on session secure/59832 protocol: 1 id: 27252 session: secure/59832 peerSessionId: 29656 active threshold ms: 4000 active interval ms: 300 idle interval ms: 500 maxTransmissions: 5 useMrp: true
2024-12-27 00:02:14.179 - debug: matter.0 (1188) 2024-12-27 00:02:14.179 DEBUG InteractionMessenger Sending DataReport chunk with 0 attributes and 0 events: 13 bytes (moreChunkedMessages: false, suppressResponse: true)
2024-12-27 00:02:14.180 - debug: matter.0 (1188) 2024-12-27 00:02:14.180 DEBUG ExchangeManager Message » id: 29656/27252/173108424 type: 1/5 acked: undefined reqAck: true duplicate: false payload: 152600a080aef8290424ff0c18
2024-12-27 00:02:14.185 - debug: matter.0 (1188) 2024-12-27 00:02:14.185 DEBUG MessageExchange Message « id: 59832/27252/210270693 type: 0/16 acked: 173108424 reqAck: false duplicate: false payload: 

@Feuer-sturm
Copy link
Collaborator

Feuer-sturm commented Dec 26, 2024

If a iobroker device will be deleted which is used in an iobroker matter bridge the red icon is not shown (🔴 )
Disabling and enabling the device in the bridge or disabling and enabling the bridge leads to showing the red icon

log
message(7).txt

@Apollon77
Copy link
Collaborator Author

Please recheck with next version

@Apollon77 Apollon77 added the fixed issue is fixed and can be retested label Dec 27, 2024
@Feuer-sturm
Copy link
Collaborator

Feuer-sturm commented Dec 28, 2024

matter 0.3.3
@Apollon77

Devices

ioBroker device created and ioBroker Matter Device created on its basis
ioBroker device deleted
Matter Device deactivated and reactivated -> error in the tab protocl (ok 🟢 ), new icon directly visible without page refres ( not ok 🔴 ), (expectction is, that the red icon will be shown without page reload)
clicking on red icon popup is shown (ok 🟢 )

Bridges

ioBroker device created and ioBroker Matter Device added to existing bridge
ioBroker device deleted
Matter Bridget deactivated and reactivated and made page refresh
red icon is not shown (not ok 🔴 ) info icon still visible

grafik

@Feuer-sturm Feuer-sturm removed the fixed issue is fixed and can be retested label Dec 28, 2024
@Apollon77
Copy link
Collaborator Author

lets close here and use #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/matter issue is relevant for backend/matter enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants