Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: allow to install scoped packages #2943

Merged
merged 5 commits into from
Nov 13, 2024
Merged

[feature]: allow to install scoped packages #2943

merged 5 commits into from
Nov 13, 2024

Conversation

foxriver76
Copy link
Collaborator

@foxriver76 foxriver76 commented Oct 17, 2024

Link the feature issue which is closed by this PR

closes #2942

Implementation details

If a repository entry has a packetName attribute this package will be installed and aliased to the raw adapter name so all paths etc are as expected. Also uninstall then simply happens by the normal adpater name.

For details see #2942

Tests

  • I have added tests to test this feature
  • It is not possible to test this feature

Documentation

  • I have documented the new feature

If this proposal is in general desirable I will add docs on this (the feature + use case)

If no tests added, please specify why it was not possible

We would need to install an scoped adapter.

@foxriver76 foxriver76 changed the title allow to install scoped packages [feature]: allow to install scoped packages Oct 17, 2024
@foxriver76 foxriver76 marked this pull request as ready for review October 31, 2024 10:09
If you then execute `npm publish`, the package will be published to your custom registry instead of the `npm` registry.

#### Vendor Repository
In your vendor-specific repository, each adapter can have a separate field called `packetName`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

field in io-package? or where?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the vendor repository as stated😀

@foxriver76 foxriver76 merged commit 784d891 into master Nov 13, 2024
15 checks passed
@foxriver76 foxriver76 deleted the issue-2942 branch November 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement]: Allow to install adapters which are scoped packages (Vendor-feature)
2 participants