setting a number value now renders a real number input #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
foxriver76
commented
Sep 1, 2023
•
foxriver76
commented
- with min/max/step support
- closes Decimal dot '.' can not be entered in object tab / manual value enter dialogue. #2083
- closes Nicht erlaubte Werte werden im Objekte-Explorer nicht abgelehnt #1099
- with min/max/step support - closes #2083
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/src/dialogs/DiscoveryDialog.tsx
Outdated
| if (typeof obj.common.licenseUrl === 'object') { | ||
| obj.common.licenseUrl = obj.common.licenseUrl[I18n.getLanguage()] || obj.common.licenseUrl.en; | ||
| } | ||
| if (obj.common.licenseUrl.includes('github.com')) { |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization
src/src/dialogs/DiscoveryDialog.tsx
Outdated
| {devicesProgress >= 99 | ||
| ? `Lookup services - ${servicesProgress}%` | ||
| : `Lookup devices - ${devicesProgress}%`} | ||
| {disableScanner && ( |
Check warning
Code scanning / CodeQL
Useless conditional
| onChange={e => this.setState({ targetValue: e.target.value })} | ||
| onKeyUp={e => e.keyCode === 13 && this.state.valid && this.onUpdate(e)} | ||
| onChange={e => { | ||
| this.setState({ targetValue: Number(e.target.value), valid: this.isNumberValid({ value: e.target.value, common: this.props.object.common }) }); |
Check warning
Code scanning / CodeQL
Potentially inconsistent state update
| @@ -489,7 +529,7 @@ | |||
| this.checkJsonError(); | |||
| } | |||
|
|
|||
| this.setState({ type: e.target.value }); | |||
| this.setState({ type: e.target.value, valid: e.target.value === 'number' ? this.isNumberValid({ value: this.state.targetValue, common: this.props.object.common }) : true }); | |||
Check warning
Code scanning / CodeQL
Potentially inconsistent state update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.