Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider stopping containers with kill #2

Open
io7m opened this issue Sep 16, 2023 · 0 comments
Open

Consider stopping containers with kill #2

io7m opened this issue Sep 16, 2023 · 0 comments
Assignees
@io7m
Labels
enhancement New feature or request

Comments

@io7m
Copy link
Member

io7m commented Sep 16, 2023

Currently, the supervisor uses podman stop to stop containers. This means that they (rarely) survive the close attempt. The supervisor should give them no choice and use podman kill to destroy the processes.

This sometimes results in:

java.io.IOException: Container process Process[pid=3558105, exitValue="not exited"] is still alive!

	at [email protected]/com.io7m.ervilla.native_exec.internal.EContainerSupervisor$EContainer.stop(EContainerSupervisor.java:919)
	at [email protected]/com.io7m.northpike.tests.containers.NPTestContainers$NPIdstoreFixture.reset(NPTestContainers.java:269)
	at [email protected]/com.io7m.northpike.tests.user_client.NPUserClientTest.setup(NPUserClientTest.java:142)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
@io7m io7m added the enhancement New feature or request label Sep 16, 2023
@io7m io7m self-assigned this Sep 16, 2023
io7m added a commit that referenced this issue Mar 31, 2024
@io7m
Allow the use of "podman kill"
f00bde9 
The method used to stop containers is now configurable. STOP is the old
"podman stop" method. KILL allows for the use of "podman kill". This
may avoid any container surviving a test execution.

Affects: #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@io7m io7m

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@io7m