Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo and tarballs include non-free file without notification #37

Closed
AdamWill opened this issue Aug 20, 2019 · 1 comment
Closed

repo and tarballs include non-free file without notification #37

AdamWill opened this issue Aug 20, 2019 · 1 comment
Assignees
Milestone

Comments

@AdamWill
Copy link
Contributor

The top-level LICENSE file is the Artistic License, and the top-level README.md file just says "This program is free software, you can redistribute it and/or modify it under the terms of the Artistic License version 2.0."

However, both the repo and the tarball distributions include two files that are not under the Artistic License - the AMQP specs in share/. The 0.8 spec is not freely licensed at all, which is a problem for distributions with strict licensing policies: in Fedora we actually have to ship a modified tarball with this file stripped out. The 0.9.1 extended spec is freely licensed, but not under the Artistic license - it is under a BSD-style license.

It'd be ideal for Fedora if the 0.8 spec was dropped and replaced with simply a reference to a URL in the README or something, as then we wouldn't have to modify the tarball every time. For the 0.9.1 extended spec, it'd be useful to add a line to the README explaining it is not under Artistic.

@SPodjasek SPodjasek added this to the 0.3 milestone Aug 20, 2019
@SPodjasek SPodjasek self-assigned this Aug 20, 2019
SPodjasek added a commit that referenced this issue Aug 20, 2019
SPodjasek added a commit that referenced this issue Aug 20, 2019
Changelog diff is:

diff --git a/Changes b/Changes
index 0430fa8..c381821 100644
--- a/Changes
+++ b/Changes
@@ -1,4 +1,6 @@
 {{$NEXT}}
+
+0.3.0 2019-08-20T20:35:39Z
   - Allow EXTERNAL as well as AMQPLAIN auth #35 (@AdamWill)
   - fixes legal issues with AMQP specs licensing #37
 0.2.4 2019-08-20T00:49:27Z
@SPodjasek
Copy link
Member

Thanks for pointing this out, fixed and released in 0.3.0

SPodjasek added a commit that referenced this issue Aug 20, 2019
Changelog diff is:

diff --git a/Changes b/Changes
index c381821..8a8a6ab 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,7 @@
 {{$NEXT}}

+0.3.1 2019-08-20T20:45:53Z
+  - Re-apply licensing note from #37 - now in proper place
 0.3.0 2019-08-20T20:35:39Z
   - Allow EXTERNAL as well as AMQPLAIN auth #35 (@AdamWill)
   - fixes legal issues with AMQP specs licensing #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants