Remove phpcsutils explicit dependency now that implicit dependency works #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytson-inviqa
added
bug
g-foster2020
previously approved these changes
Apr 26, 2023
php-compatibility required previously an alpha package, which we added this explicit dependency to solve, however now that version is not supported by php-compatibility
andytson-inviqa
force-pushed
the
feature/phpcsutils-version-fix
branch
from
6d3f748 to
7196f6f
Compare
g-foster2020
previously approved these changes
Apr 27, 2023
andytson-inviqa
changed the title
andytson-inviqa
added
harness-magento1
g-foster2020
approved these changes
Apr 28, 2023
|
going to split this #772 out for a passing build, to avoid building everything multiple times |
|
oh, forgot I'd gotten auto-merge enabled. oh well, will close #772 then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-compatibility required previously an alpha package, which we added this explicit dependency to solve, however now that version is not supported by php-compatibility
In hindsight,
~1.0.0@alpha, ^1.0might have been better