Create ns with kubectl when using helm3 #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytson-inviqa
previously approved these changes
May 24, 2022
* Ignore in the phpstan baseline ``` ------ ----------------------------------------------------------------------- Line Pyz/Client/Catalog/CatalogDependencyProvider.php ------ ----------------------------------------------------------------------- 147 Parameter inviqa#1 $rawCatalogSearchResultFormatterPlugin of class Spryker\Client\CatalogPriceProductConnector\Plugin\CurrencyAwareSugge stionByTypeResultFormatter constructor expects Spryker\Client\Search\Dependency\Plugin\ResultFormatterPluginInterfac e, Spryker\Client\SearchElasticsearch\Plugin\ResultFormatter\SuggestionB yTypeResultFormatterPlugin given. ------ ----------------------------------------------------------------------- ``` * Downgrade phpstan to 1.6.9 as it is having issues with class_alias()
kierenevans
approved these changes
Nov 8, 2022
andytson
reviewed
Nov 8, 2022
| @@ -91,6 +91,9 @@ command('app deploy <environment>'): | |||
| if helm version --short --client | grep '^Client: v2' >/dev/null 2>&1; then | |||
| passthru helm init --client-only | |||
| fi | |||
| if helm version --short --client | grep '^v3' >/dev/null 2>&1; then | |||
| kubectl --kubeconfig="${PWD}/kubectl.config.yaml" create ns "${NAMESPACE}" || true | |||
| fi | |||
There was a problem hiding this comment.
needs to be conditional for if the k8s server doesn't allow ns creation to the user. Not all uses will be necessarily for feature branch environments only, and so static environments may have namespace already created.
can't presume also can list namespaces either to check if it exists, although kubectl get namespace "${NAMESPACE}" might be useable.
There was a problem hiding this comment.
ah, nvm I forgot I mentioned this before, and the || true stops it causing breakage
andytson-inviqa
added
enhancement
andytson-inviqa
added a commit
to inviqa/harness-docker
that referenced
this pull request
Jun 8, 2023
* inviqa/harness-base-php#727 * inviqa/harness-base-php#760 * inviqa/harness-base-php#752 * inviqa/harness-base-php#717 * inviqa/harness-base-php#777 * inviqa/harness-base-php#686 * inviqa/harness-base-php#713 * inviqa/harness-base-php#770 * inviqa/harness-base-php#759 * inviqa/harness-base-php#707 - except v2 rather than v1
andytson-inviqa
added a commit
to inviqa/harness-docker
that referenced
this pull request
Jun 8, 2023
* inviqa/harness-base-php#727 * inviqa/harness-base-php#760 * inviqa/harness-base-php#752 * inviqa/harness-base-php#717 * inviqa/harness-base-php#777 * inviqa/harness-base-php#686 * inviqa/harness-base-php#713 * inviqa/harness-base-php#770 * inviqa/harness-base-php#759 * inviqa/harness-base-php#707 - except v2 rather than v1
andytson-inviqa
added a commit
to inviqa/harness-docker
that referenced
this pull request
Jun 8, 2023
* inviqa/harness-base-php#727 * inviqa/harness-base-php#760 * inviqa/harness-base-php#752 * inviqa/harness-base-php#717 * inviqa/harness-base-php#777 * inviqa/harness-base-php#686 * inviqa/harness-base-php#713 * inviqa/harness-base-php#770 * inviqa/harness-base-php#759 * inviqa/harness-base-php#707 - except v2 rather than v1
andytson-inviqa
added a commit
to inviqa/harness-docker
that referenced
this pull request
Jun 8, 2023
* inviqa/harness-base-php#727 * inviqa/harness-base-php#760 * inviqa/harness-base-php#752 * inviqa/harness-base-php#717 * inviqa/harness-base-php#777 * inviqa/harness-base-php#686 * inviqa/harness-base-php#713 * inviqa/harness-base-php#770 * inviqa/harness-base-php#759 * inviqa/harness-base-php#707 - except v2 rather than v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
When using helm3, the
app deploy previewdoesn't work because the namespace it's missing.The solution is to create the k8s namespace right before running helm to ensure there is a k8s namespace in place.