#67 Detect if containers exist during ws enable
#517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierenevans
added
enhancement
hgajjar
reviewed
Jan 7, 2021
| if [ "$IS_BUILT" = "no" ]; then | ||
| if [ "$HAS_FLAG" = "no" ]; then | ||
| passthru docker-compose down | ||
| fi |
There was a problem hiding this comment.
So if the setup process is halted by something, it would retry the setup from where it stopped instead of removing everything and starting from scratch?
There was a problem hiding this comment.
If the setup process stops, the flag is never created, so would still bring containers down to try again.
There was a problem hiding this comment.
ah right, I was thinking about an existing env, where I retry the setup and it stops, but then the retry step would/should have removed the flag, all good 👍
hgajjar
previously approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no containers are available for the project but .my127ws/.flag-built still exists, count it as needing to build the project as containers would be brought up without any database volumes.
Fixes #67