Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust workspace or pipeline host for drupal #482

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

kierenevans
Copy link
Contributor

Using APP_HOST environment variable, configure drupal's trusted host settings.

Documentation: https://www.drupal.org/docs/installing-drupal/trusted-host-settings

@kierenevans kierenevans added enhancement New feature or request harness-drupal8 Drupal 8.x harness, obsolete as of 1.5.x labels Nov 4, 2020
@kierenevans kierenevans added this to the 0.12.0 milestone Nov 4, 2020
@kierenevans kierenevans marked this pull request as ready for review November 13, 2020 13:15
Copy link
Contributor

@andytson-inviqa andytson-inviqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little concerned about backwards compatibility and how multi-site hosts would handle it

@kierenevans
Copy link
Contributor Author

Most projects I've seen are customising this file in their overlay directory anyway. Sometimes to only add the trusted host pattern.

@kierenevans kierenevans merged commit 5baf4a2 into 0.12.x Dec 8, 2020
@kierenevans kierenevans deleted the feature/trust-workspace-or-pipeline-host branch December 8, 2020 09:18
@andytson-inviqa andytson-inviqa added this to the 0.12.0 milestone Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request harness-drupal8 Drupal 8.x harness, obsolete as of 1.5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants