Define service resources from within services.{service}.resources values #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytson-inviqa
added
enhancement
andytson-inviqa
force-pushed
the
feature/resources-services
branch
3 times, most recently
from
7eb3ef9 to
564f78e
Compare
kierenevans
reviewed
Oct 23, 2020
src/_base/helm/app/templates/service/elasticsearch/deployment.yaml
Outdated
Show resolved
Hide resolved
andytson-inviqa
commented
Oct 23, 2020
src/_base/helm/app/templates/service/elasticsearch/deployment.yaml
Outdated
Show resolved
Hide resolved
andytson-inviqa
force-pushed
the
feature/resources-services
branch
3 times, most recently
from
51a0a26 to
a3a8307
Compare
This deprecates the use of resources.memory.{service}, except for job resources (e.g. app-init/app-migrate, which don't have a similar abstraction yet)
Also the helm/_twig/values.yaml/resources.yml.twig is also deprecated, as unnecessary with serialisation of resources to yaml
Co-authored-by: Kieren Evans <[email protected]>
Co-authored-by: Kieren Evans <[email protected]>
And convert the non-_base deployments to the same style as _base
andytson-inviqa
force-pushed
the
feature/resources-services
branch
from
637a5af to
25c4896
Compare
kierenevans
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the use of resources.memory.{service}, except for job resources (e.g. app-init/app-migrate, which don't have a similar abstraction yet)
Also the helm/_twig/values.yaml/resources.yml.twig is also deprecated, as unnecessary with serialisation of resources to yaml