Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akeneo - fix random build failures #426

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

kierenevans
Copy link
Contributor

  • Wait for elasticsearch before install
  • Bring up console first, so it can do it's entrypoint.dynamic.sh chown of /app to match the build user.
  • Then bring up php-fpm and everything else, so www-data will be the same UID as the build user and be able to write to var/logs/dev.log.

Previously, UID 1000 owned the /app/var/ folder but www-data was UID 33 still, due to a parallel startup.

@kierenevans kierenevans added bug Something isn't working harness-php PHP harness harness-akeneo Akeneo harness labels Sep 26, 2020
@kierenevans kierenevans added this to the 0.10.0 milestone Sep 26, 2020
@kierenevans kierenevans self-assigned this Sep 28, 2020
Copy link

@tkotosz tkotosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, you might need to add the wait to the migrate steps as well but I don't know how akeneo works so 👍

@kierenevans
Copy link
Contributor Author

doctrine migrations aren't talking to elasticsearch so should be okay 🤞

@kierenevans kierenevans merged commit 1b15067 into 0.10.x Sep 29, 2020
@kierenevans kierenevans deleted the feature/wait-for-elasticsearch-before-install branch September 29, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working harness-akeneo Akeneo harness harness-php PHP harness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants