-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Spryker 202009 release #398
Merged
Merged
Changes from 15 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
2d73725
Change spryker version in config
9685f3e
Fix dependency issues
ec2ceab
Update behat config
d1fe5e4
Remove db_engine config
d9ceff3
Change spryker version in config
14999df
Fix dependency issues
c1afb42
Update behat config
82abe52
Remove db_engine config
bad347d
Merge branch 'feature/update-spryker-version' of github.com:inviqa/ha…
8ce7969
Update installation recipe as per spryker cli command changes
9a9610a
Ignore .idea dir
603382a
Run development command only in development mode
f3edcbe
Config changes
8ec5511
Add fix values for oauth credentials
5abbe30
Spryker demoshop is not compatible with phpstan level 5
5e069e1
Merge branch '0.11.x' into feature/update-spryker-version
16cbf57
Add baseline for phpstan to run it with level 5
804a420
Use latest php/redis/es versions supported by latest Spryker release
ae8dce8
Remove fixed secrets and add helper command to generate them
9db64b7
Switch to development mode before after creating images in CI
9bcfa55
Revert "Switch to development mode before after creating images in CI"
f859fee
Allow injecting spryker oauth secrets from Jenkins CI env
7226e08
Use encrypted value for CI env
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
/github-changelog-http-cache/ | ||
/tests/ | ||
/tmp-test/ | ||
.idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletions
4
src/spryker/application/skeleton/features/bootstrap/_config/contexts.yml
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #446 to convert these values to secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, we can't release this PR as a harness version without that though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true. I'm happy to work on that ticket and create a child PR of this one, but need help to understand how to do it.
I think I can convert these values to workspace encrypted attributes for development env, but not sure how we would generate them during project setup using some twig function, also no idea how to generate sealed secrets for them at run time.
It would be nice if we can pair on it @andytson-inviqa or @kierenevans 😄