-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation for setting up workspace on Drupal projects #281
Conversation
This is really amazing to see. Thank you! |
In `workspace.yml` add: | ||
```yaml | ||
attribute('mysql.image'): quay.io/continuouspipe/mysql5.7 | ||
attribute('mysql.tag'): latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kierenevans, I've left this as latest
for now. Will the continouspipe image be updated or should I change this to either use stable
or add the grants in the install steps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update to use the init step grants instead of the CP image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - my concern with that approach is that they don't trigger once you have a DB dump in tools/assets
. Probably not an issue for the initial install, but if someone destroys and re-installs then the databases won't be created.
Taking a look at other options, would it work if we created them in the before('harness.install')
event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's triggered too early to use against a running container: https://github.com/my127/workspace/blob/0.1.x/src/Types/Workspace/Installer.php#L79
The ws enable
command is called by the after.harness.install
event triggered here:
https://github.com/my127/workspace/blob/0.1.x/src/Types/Workspace/Installer.php#L97
and received here:
harness-base-php/src/_base/harness/config/events.yml
Lines 2 to 4 in 17d88d3
after('harness.install'): | | |
#!bash | |
ws enable |
Only then is the set of docker containers brought up.
After that we are left with either build step, install step, init step, or customising enable.sh
to be able to do extra things in between.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - my concern with that approach is that they don't trigger once you have a DB dump in
tools/assets
.
I think that's why we did the grants as the init step rather than install step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use the init steps.
└- tools/ | ||
. └- assets/ | ||
. . └- development/ | ||
. . . ├- drupal.sql.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs updated to one_site.sql.gz
bacdddb
to
2e82cdb
Compare
…rom harness-drupal8
@sawtell are you okay to review my changes in the last 7 commits? https://github.com/inviqa/harness-base-php/pull/281/files/ca6adca9db84d5a7335279207d657bdf5fe67ced..d06b37f0861daf6debd5ff493c2dd0273cbcfea6 Thanks! |
Hi @kierenevans, I can't approve them, but they look great! Thanks for fixing the bugs and improved explanations. 👍 |
This PR adds documentation for the Drupal 8 harness.
The documentation covers: